Skip to content

Conversation

@leahkiner
Copy link
Contributor

Description

This PR addresses 5 issues related to adding the capability to connect other state effectors to the prescribed motion module rather than the spacecraft hub.

  • The first commit modifies the stateEffector class for attachment of state effectors to the prescribed motion effector.
  • The second commit is independent of the purpose of this PR, it removes unneeded variables from the prescribedMotion module.
  • The third commit makes the required changes to the prescribedMotion module to enable the new branching capability.
  • The fourth commit is also independent of the purpose of this PR, it adds setters and getters to the prescribedMotion module.
  • Commits 5-7 configure the spinningBodyOneDOF, spinningBodyTwoDOF, and linearTranslationOneDOF state effectors for optional attachment to the prescribed motion effector.
  • Commit 8 adds a new test script called test_PrescribedMotionStateEffectorBranching to the prescribed motion module. Each of these three state effectors are separately attached to the prescribed motion effector and independently verified.
  • Commit 9 adds two branching scenarios to the examples folder. The first is a rotational branching scenario called scenarioPrescribedMotionWithRotationBranching. The second is a translational branching scenario and is called scenarioPrescribedMotionWithTranslationBranching.
  • Commit 10 condenses the branching scenarios using python lists.
  • Commit 11 refactors and cleans up the original prescribed motion test script.
  • Commit 12 updates the prescribed motion module documentation to reflect these changes.
  • Commit 13 updates bskReleaseNotes.

Verification

A new test script test_PrescribedMotionStateEffectorBranching is added to the prescribedMotion module that checks the changes made in this PR.

Documentation

The prescribed motion module documentation is updated to discuss these new features.

Future work

Other state effectors will be configured for attachment to the prescribed motion effector in the future.

@leahkiner leahkiner self-assigned this Oct 7, 2025
@leahkiner leahkiner requested a review from a team as a code owner October 7, 2025 21:56
@leahkiner leahkiner added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 7, 2025
@leahkiner leahkiner moved this to 👀 In review in Basilisk Oct 7, 2025
@leahkiner leahkiner force-pushed the feature/932-configure-prescribed-motion-for-effector-branching branch from 1301065 to 0d84979 Compare October 9, 2025 22:37
@leahkiner leahkiner force-pushed the feature/932-configure-prescribed-motion-for-effector-branching branch 10 times, most recently from 63f379c to f0b70b8 Compare October 28, 2025 17:57
@leahkiner leahkiner force-pushed the feature/932-configure-prescribed-motion-for-effector-branching branch from f0b70b8 to 77aa7a1 Compare October 28, 2025 18:21
@schaubh schaubh changed the title Feature/932 configure prescribed motion for effector branching Configure prescribed motion effector for select effector branching Oct 28, 2025
@leahkiner leahkiner force-pushed the feature/932-configure-prescribed-motion-for-effector-branching branch from 77aa7a1 to 20788df Compare October 28, 2025 22:18
@leahkiner leahkiner force-pushed the feature/932-configure-prescribed-motion-for-effector-branching branch from 20788df to 983aa58 Compare October 29, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: 👀 In review

2 participants